gitea源码

1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889909192939495969798991001011021031041051061071081091101111121131141151161171181191201211221231241251261271281291301311321331341351361371381391401411421431441451461471481491501511521531541551561571581591601611621631641651661671681691701711721731741751761771781791801811821831841851861871881891901911921931941951961971981992002012022032042052062072082092102112122132142152162172182192202212222232242252262272282292302312322332342352362372382392402412422432442452462472482492502512522532542552562572582592602612622632642652662672682692702712722732742752762772782792802812822832842852862872882892902912922932942952962972982993003013023033043053063073083093103113123133143153163173183193203213223233243253263273283293303313323333343353363373383393403413423433443453463473483493503513523533543553563573583593603613623633643653663673683693703713723733743753763773783793803813823833843853863873883893903913923933943953963973983994004014024034044054064074084094104114124134144154164174184194204214224234244254264274284294304314324334344354364374384394404414424434444454464474484494504514524534544554564574584594604614624634644654664674684694704714724734744754764774784794804814824834844854864874884894904914924934944954964974984995005015025035045055065075085095105115125135145155165175185195205215225235245255265275285295305315325335345355365375385395405415425435445455465475485495505515525535545555565575585595605615625635645655665675685695705715725735745755765775785795805815825835845855865875885895905915925935945955965975985996006016026036046056066076086096106116126136146156166176186196206216226236246256266276286296306316326336346356366376386396406416426436446456466476486496506516526536546556566576586596606616626636646656666676686696706716726736746756766776786796806816826836846856866876886896906916926936946956966976986997007017027037047057067077087097107117127137147157167177187197207217227237247257267277287297307317327337347357367377387397407417427437447457467477487497507517527537547557567577587597607617627637647657667677687697707717727737747757767777787797807817827837847857867877887897907917927937947957967977987998008018028038048058068078088098108118128138148158168178188198208218228238248258268278288298308318328338348358368378388398408418428438448458468478488498508518528538548558568578588598608618628638648658668678688698708718728738748758768778788798808818828838848858868878888898908918928938948958968978988999009019029039049059069079089099109119129139149159169179189199209219229239249259269279289299309319329339349359369379389399409419429439449459469479489499509519529539549559569579589599609619629639649659669679689699709719729739749759769779789799809819829839849859869879889899909919929939949959969979989991000100110021003100410051006100710081009101010111012101310141015101610171018101910201021102210231024102510261027102810291030103110321033103410351036103710381039104010411042104310441045104610471048104910501051105210531054105510561057
  1. // Copyright 2018 The Gitea Authors. All rights reserved.
  2. // SPDX-License-Identifier: MIT
  3. package issues
  4. import (
  5. "context"
  6. "errors"
  7. "fmt"
  8. "slices"
  9. "strings"
  10. "code.gitea.io/gitea/models/db"
  11. git_model "code.gitea.io/gitea/models/git"
  12. "code.gitea.io/gitea/models/organization"
  13. "code.gitea.io/gitea/models/perm"
  14. access_model "code.gitea.io/gitea/models/perm/access"
  15. "code.gitea.io/gitea/models/unit"
  16. user_model "code.gitea.io/gitea/models/user"
  17. "code.gitea.io/gitea/modules/structs"
  18. "code.gitea.io/gitea/modules/timeutil"
  19. "code.gitea.io/gitea/modules/util"
  20. "xorm.io/builder"
  21. )
  22. // ErrReviewNotExist represents a "ReviewNotExist" kind of error.
  23. type ErrReviewNotExist struct {
  24. ID int64
  25. }
  26. // IsErrReviewNotExist checks if an error is a ErrReviewNotExist.
  27. func IsErrReviewNotExist(err error) bool {
  28. _, ok := err.(ErrReviewNotExist)
  29. return ok
  30. }
  31. func (err ErrReviewNotExist) Error() string {
  32. return fmt.Sprintf("review does not exist [id: %d]", err.ID)
  33. }
  34. func (err ErrReviewNotExist) Unwrap() error {
  35. return util.ErrNotExist
  36. }
  37. // ErrNotValidReviewRequest an not allowed review request modify
  38. type ErrNotValidReviewRequest struct {
  39. Reason string
  40. UserID int64
  41. RepoID int64
  42. }
  43. // IsErrNotValidReviewRequest checks if an error is a ErrNotValidReviewRequest.
  44. func IsErrNotValidReviewRequest(err error) bool {
  45. _, ok := err.(ErrNotValidReviewRequest)
  46. return ok
  47. }
  48. func (err ErrNotValidReviewRequest) Error() string {
  49. return fmt.Sprintf("%s [user_id: %d, repo_id: %d]",
  50. err.Reason,
  51. err.UserID,
  52. err.RepoID)
  53. }
  54. func (err ErrNotValidReviewRequest) Unwrap() error {
  55. return util.ErrInvalidArgument
  56. }
  57. // ErrReviewRequestOnClosedPR represents an error when an user tries to request a re-review on a closed or merged PR.
  58. type ErrReviewRequestOnClosedPR struct{}
  59. // IsErrReviewRequestOnClosedPR checks if an error is an ErrReviewRequestOnClosedPR.
  60. func IsErrReviewRequestOnClosedPR(err error) bool {
  61. _, ok := err.(ErrReviewRequestOnClosedPR)
  62. return ok
  63. }
  64. func (err ErrReviewRequestOnClosedPR) Error() string {
  65. return "cannot request a re-review on a closed or merged PR"
  66. }
  67. func (err ErrReviewRequestOnClosedPR) Unwrap() error {
  68. return util.ErrPermissionDenied
  69. }
  70. // ReviewType defines the sort of feedback a review gives
  71. type ReviewType int
  72. // ReviewTypeUnknown unknown review type
  73. const ReviewTypeUnknown ReviewType = -1
  74. const (
  75. // ReviewTypePending is a review which is not published yet
  76. ReviewTypePending ReviewType = iota
  77. // ReviewTypeApprove approves changes
  78. ReviewTypeApprove
  79. // ReviewTypeComment gives general feedback
  80. ReviewTypeComment
  81. // ReviewTypeReject gives feedback blocking merge
  82. ReviewTypeReject
  83. // ReviewTypeRequest request review from others
  84. ReviewTypeRequest
  85. )
  86. // Icon returns the corresponding icon for the review type
  87. func (rt ReviewType) Icon() string {
  88. switch rt {
  89. case ReviewTypeApprove:
  90. return "check"
  91. case ReviewTypeReject:
  92. return "diff"
  93. case ReviewTypeComment:
  94. return "comment"
  95. case ReviewTypeRequest:
  96. return "dot-fill"
  97. default:
  98. return "comment"
  99. }
  100. }
  101. // Review represents collection of code comments giving feedback for a PR
  102. type Review struct {
  103. ID int64 `xorm:"pk autoincr"`
  104. Type ReviewType
  105. Reviewer *user_model.User `xorm:"-"`
  106. ReviewerID int64 `xorm:"index"`
  107. ReviewerTeamID int64 `xorm:"NOT NULL DEFAULT 0"`
  108. ReviewerTeam *organization.Team `xorm:"-"`
  109. OriginalAuthor string
  110. OriginalAuthorID int64
  111. Issue *Issue `xorm:"-"`
  112. IssueID int64 `xorm:"index"`
  113. Content string `xorm:"TEXT"`
  114. // Official is a review made by an assigned approver (counts towards approval)
  115. Official bool `xorm:"NOT NULL DEFAULT false"`
  116. CommitID string `xorm:"VARCHAR(64)"`
  117. Stale bool `xorm:"NOT NULL DEFAULT false"`
  118. Dismissed bool `xorm:"NOT NULL DEFAULT false"`
  119. CreatedUnix timeutil.TimeStamp `xorm:"INDEX created"`
  120. UpdatedUnix timeutil.TimeStamp `xorm:"INDEX updated"`
  121. // CodeComments are the initial code comments of the review
  122. CodeComments CodeComments `xorm:"-"`
  123. Comments []*Comment `xorm:"-"`
  124. }
  125. func init() {
  126. db.RegisterModel(new(Review))
  127. }
  128. // LoadCodeComments loads CodeComments
  129. func (r *Review) LoadCodeComments(ctx context.Context) (err error) {
  130. if r.CodeComments != nil {
  131. return err
  132. }
  133. if err = r.LoadIssue(ctx); err != nil {
  134. return err
  135. }
  136. r.CodeComments, err = fetchCodeCommentsByReview(ctx, r.Issue, nil, r, false)
  137. return err
  138. }
  139. func (r *Review) LoadIssue(ctx context.Context) (err error) {
  140. if r.Issue != nil {
  141. return err
  142. }
  143. r.Issue, err = GetIssueByID(ctx, r.IssueID)
  144. return err
  145. }
  146. // LoadReviewer loads reviewer
  147. func (r *Review) LoadReviewer(ctx context.Context) (err error) {
  148. if r.ReviewerID == 0 || r.Reviewer != nil {
  149. return err
  150. }
  151. r.Reviewer, err = user_model.GetPossibleUserByID(ctx, r.ReviewerID)
  152. if err != nil {
  153. if !user_model.IsErrUserNotExist(err) {
  154. return fmt.Errorf("GetPossibleUserByID [%d]: %w", r.ReviewerID, err)
  155. }
  156. r.ReviewerID = user_model.GhostUserID
  157. r.Reviewer = user_model.NewGhostUser()
  158. return nil
  159. }
  160. return err
  161. }
  162. // LoadReviewerTeam loads reviewer team
  163. func (r *Review) LoadReviewerTeam(ctx context.Context) (err error) {
  164. if r.ReviewerTeamID == 0 || r.ReviewerTeam != nil {
  165. return nil
  166. }
  167. r.ReviewerTeam, err = organization.GetTeamByID(ctx, r.ReviewerTeamID)
  168. return err
  169. }
  170. // LoadAttributes loads all attributes except CodeComments
  171. func (r *Review) LoadAttributes(ctx context.Context) (err error) {
  172. if err = r.LoadIssue(ctx); err != nil {
  173. return err
  174. }
  175. if err = r.LoadCodeComments(ctx); err != nil {
  176. return err
  177. }
  178. if err = r.LoadReviewer(ctx); err != nil {
  179. return err
  180. }
  181. if err = r.LoadReviewerTeam(ctx); err != nil {
  182. return err
  183. }
  184. return err
  185. }
  186. // HTMLTypeColorName returns the color used in the ui indicating the review
  187. func (r *Review) HTMLTypeColorName() string {
  188. switch r.Type {
  189. case ReviewTypeApprove:
  190. if !r.Official {
  191. return "grey"
  192. }
  193. if r.Stale {
  194. return "yellow"
  195. }
  196. return "green"
  197. case ReviewTypeComment:
  198. return "grey"
  199. case ReviewTypeReject:
  200. return "red"
  201. case ReviewTypeRequest:
  202. return "yellow"
  203. }
  204. return "grey"
  205. }
  206. // TooltipContent returns the locale string describing the review type
  207. func (r *Review) TooltipContent() string {
  208. switch r.Type {
  209. case ReviewTypeApprove:
  210. if r.Stale {
  211. return "repo.issues.review.stale"
  212. }
  213. if !r.Official {
  214. return "repo.issues.review.unofficial"
  215. }
  216. return "repo.issues.review.official"
  217. case ReviewTypeComment:
  218. return "repo.issues.review.commented"
  219. case ReviewTypeReject:
  220. return "repo.issues.review.rejected"
  221. case ReviewTypeRequest:
  222. return "repo.issues.review.requested"
  223. }
  224. return ""
  225. }
  226. // GetReviewByID returns the review by the given ID
  227. func GetReviewByID(ctx context.Context, id int64) (*Review, error) {
  228. review := new(Review)
  229. if has, err := db.GetEngine(ctx).ID(id).Get(review); err != nil {
  230. return nil, err
  231. } else if !has {
  232. return nil, ErrReviewNotExist{ID: id}
  233. }
  234. return review, nil
  235. }
  236. // CreateReviewOptions represent the options to create a review. Type, Issue and Reviewer are required.
  237. type CreateReviewOptions struct {
  238. Content string
  239. Type ReviewType
  240. Issue *Issue
  241. Reviewer *user_model.User
  242. ReviewerTeam *organization.Team
  243. Official bool
  244. CommitID string
  245. Stale bool
  246. }
  247. // IsOfficialReviewer check if at least one of the provided reviewers can make official reviews in issue (counts towards required approvals)
  248. func IsOfficialReviewer(ctx context.Context, issue *Issue, reviewer *user_model.User) (bool, error) {
  249. if err := issue.LoadPullRequest(ctx); err != nil {
  250. return false, err
  251. }
  252. pr := issue.PullRequest
  253. rule, err := git_model.GetFirstMatchProtectedBranchRule(ctx, pr.BaseRepoID, pr.BaseBranch)
  254. if err != nil {
  255. return false, err
  256. }
  257. if rule == nil {
  258. // if no rule is found, then user with write access can make official reviews
  259. err := pr.LoadBaseRepo(ctx)
  260. if err != nil {
  261. return false, err
  262. }
  263. writeAccess, err := access_model.HasAccessUnit(ctx, reviewer, pr.BaseRepo, unit.TypeCode, perm.AccessModeWrite)
  264. if err != nil {
  265. return false, err
  266. }
  267. return writeAccess, nil
  268. }
  269. official, err := git_model.IsUserOfficialReviewer(ctx, rule, reviewer)
  270. if official || err != nil {
  271. return official, err
  272. }
  273. return false, nil
  274. }
  275. // IsOfficialReviewerTeam check if reviewer in this team can make official reviews in issue (counts towards required approvals)
  276. func IsOfficialReviewerTeam(ctx context.Context, issue *Issue, team *organization.Team) (bool, error) {
  277. if err := issue.LoadPullRequest(ctx); err != nil {
  278. return false, err
  279. }
  280. pb, err := git_model.GetFirstMatchProtectedBranchRule(ctx, issue.PullRequest.BaseRepoID, issue.PullRequest.BaseBranch)
  281. if err != nil {
  282. return false, err
  283. }
  284. if pb == nil {
  285. return false, nil
  286. }
  287. if !pb.EnableApprovalsWhitelist {
  288. return team.UnitAccessMode(ctx, unit.TypeCode) >= perm.AccessModeWrite, nil
  289. }
  290. return slices.Contains(pb.ApprovalsWhitelistTeamIDs, team.ID), nil
  291. }
  292. // CreateReview creates a new review based on opts
  293. func CreateReview(ctx context.Context, opts CreateReviewOptions) (*Review, error) {
  294. return db.WithTx2(ctx, func(ctx context.Context) (*Review, error) {
  295. sess := db.GetEngine(ctx)
  296. review := &Review{
  297. Issue: opts.Issue,
  298. IssueID: opts.Issue.ID,
  299. Reviewer: opts.Reviewer,
  300. ReviewerTeam: opts.ReviewerTeam,
  301. Content: opts.Content,
  302. Official: opts.Official,
  303. CommitID: opts.CommitID,
  304. Stale: opts.Stale,
  305. }
  306. if opts.Reviewer != nil {
  307. review.Type = opts.Type
  308. review.ReviewerID = opts.Reviewer.ID
  309. reviewCond := builder.Eq{"reviewer_id": opts.Reviewer.ID, "issue_id": opts.Issue.ID}
  310. // make sure user review requests are cleared
  311. if opts.Type != ReviewTypePending {
  312. if _, err := sess.Where(reviewCond.And(builder.Eq{"type": ReviewTypeRequest})).Delete(new(Review)); err != nil {
  313. return nil, err
  314. }
  315. }
  316. // make sure if the created review gets dismissed no old review surface
  317. // other types can be ignored, as they don't affect branch protection
  318. if opts.Type == ReviewTypeApprove || opts.Type == ReviewTypeReject {
  319. if _, err := sess.Where(reviewCond.And(builder.In("type", ReviewTypeApprove, ReviewTypeReject))).
  320. Cols("dismissed").Update(&Review{Dismissed: true}); err != nil {
  321. return nil, err
  322. }
  323. }
  324. } else if opts.ReviewerTeam != nil {
  325. review.Type = ReviewTypeRequest
  326. review.ReviewerTeamID = opts.ReviewerTeam.ID
  327. } else {
  328. return nil, errors.New("provide either reviewer or reviewer team")
  329. }
  330. if _, err := sess.Insert(review); err != nil {
  331. return nil, err
  332. }
  333. return review, nil
  334. })
  335. }
  336. // GetCurrentReview returns the current pending review of reviewer for given issue
  337. func GetCurrentReview(ctx context.Context, reviewer *user_model.User, issue *Issue) (*Review, error) {
  338. if reviewer == nil {
  339. return nil, nil
  340. }
  341. reviews, err := FindReviews(ctx, FindReviewOptions{
  342. Types: []ReviewType{ReviewTypePending},
  343. IssueID: issue.ID,
  344. ReviewerID: reviewer.ID,
  345. })
  346. if err != nil {
  347. return nil, err
  348. }
  349. if len(reviews) == 0 {
  350. return nil, ErrReviewNotExist{}
  351. }
  352. reviews[0].Reviewer = reviewer
  353. reviews[0].Issue = issue
  354. return reviews[0], nil
  355. }
  356. // ReviewExists returns whether a review exists for a particular line of code in the PR
  357. func ReviewExists(ctx context.Context, issue *Issue, treePath string, line int64) (bool, error) {
  358. return db.GetEngine(ctx).Cols("id").Exist(&Comment{IssueID: issue.ID, TreePath: treePath, Line: line, Type: CommentTypeCode})
  359. }
  360. // ContentEmptyErr represents an content empty error
  361. type ContentEmptyErr struct{}
  362. func (ContentEmptyErr) Error() string {
  363. return "Review content is empty"
  364. }
  365. // IsContentEmptyErr returns true if err is a ContentEmptyErr
  366. func IsContentEmptyErr(err error) bool {
  367. _, ok := err.(ContentEmptyErr)
  368. return ok
  369. }
  370. // SubmitReview creates a review out of the existing pending review or creates a new one if no pending review exist
  371. func SubmitReview(ctx context.Context, doer *user_model.User, issue *Issue, reviewType ReviewType, content, commitID string, stale bool, attachmentUUIDs []string) (*Review, *Comment, error) {
  372. ctx, committer, err := db.TxContext(ctx)
  373. if err != nil {
  374. return nil, nil, err
  375. }
  376. defer committer.Close()
  377. sess := db.GetEngine(ctx)
  378. official := false
  379. review, err := GetCurrentReview(ctx, doer, issue)
  380. if err != nil {
  381. if !IsErrReviewNotExist(err) {
  382. return nil, nil, err
  383. }
  384. if reviewType != ReviewTypeApprove && len(strings.TrimSpace(content)) == 0 {
  385. return nil, nil, ContentEmptyErr{}
  386. }
  387. if reviewType == ReviewTypeApprove || reviewType == ReviewTypeReject {
  388. // Only reviewers latest review of type approve and reject shall count as "official", so existing reviews needs to be cleared
  389. if _, err := db.Exec(ctx, "UPDATE `review` SET official=? WHERE issue_id=? AND reviewer_id=?", false, issue.ID, doer.ID); err != nil {
  390. return nil, nil, err
  391. }
  392. if official, err = IsOfficialReviewer(ctx, issue, doer); err != nil {
  393. return nil, nil, err
  394. }
  395. }
  396. // No current review. Create a new one!
  397. if review, err = CreateReview(ctx, CreateReviewOptions{
  398. Type: reviewType,
  399. Issue: issue,
  400. Reviewer: doer,
  401. Content: content,
  402. Official: official,
  403. CommitID: commitID,
  404. Stale: stale,
  405. }); err != nil {
  406. return nil, nil, err
  407. }
  408. } else {
  409. if err := review.LoadCodeComments(ctx); err != nil {
  410. return nil, nil, err
  411. }
  412. if reviewType != ReviewTypeApprove && len(review.CodeComments) == 0 && len(strings.TrimSpace(content)) == 0 {
  413. return nil, nil, ContentEmptyErr{}
  414. }
  415. if reviewType == ReviewTypeApprove || reviewType == ReviewTypeReject {
  416. // Only reviewers latest review of type approve and reject shall count as "official", so existing reviews needs to be cleared
  417. if _, err := db.Exec(ctx, "UPDATE `review` SET official=? WHERE issue_id=? AND reviewer_id=?", false, issue.ID, doer.ID); err != nil {
  418. return nil, nil, err
  419. }
  420. if official, err = IsOfficialReviewer(ctx, issue, doer); err != nil {
  421. return nil, nil, err
  422. }
  423. }
  424. review.Official = official
  425. review.Issue = issue
  426. review.Content = content
  427. review.Type = reviewType
  428. review.CommitID = commitID
  429. review.Stale = stale
  430. if _, err := sess.ID(review.ID).Cols("content, type, official, commit_id, stale").Update(review); err != nil {
  431. return nil, nil, err
  432. }
  433. }
  434. comm, err := CreateComment(ctx, &CreateCommentOptions{
  435. Type: CommentTypeReview,
  436. Doer: doer,
  437. Content: review.Content,
  438. Issue: issue,
  439. Repo: issue.Repo,
  440. ReviewID: review.ID,
  441. Attachments: attachmentUUIDs,
  442. })
  443. if err != nil || comm == nil {
  444. return nil, nil, err
  445. }
  446. // try to remove team review request if need
  447. if issue.Repo.Owner.IsOrganization() && (reviewType == ReviewTypeApprove || reviewType == ReviewTypeReject) {
  448. teamReviewRequests := make([]*Review, 0, 10)
  449. if err := sess.SQL("SELECT * FROM review WHERE issue_id = ? AND reviewer_team_id > 0 AND type = ?", issue.ID, ReviewTypeRequest).Find(&teamReviewRequests); err != nil {
  450. return nil, nil, err
  451. }
  452. for _, teamReviewRequest := range teamReviewRequests {
  453. ok, err := organization.IsTeamMember(ctx, issue.Repo.OwnerID, teamReviewRequest.ReviewerTeamID, doer.ID)
  454. if err != nil {
  455. return nil, nil, err
  456. } else if !ok {
  457. continue
  458. }
  459. if _, err := db.DeleteByID[Review](ctx, teamReviewRequest.ID); err != nil {
  460. return nil, nil, err
  461. }
  462. }
  463. }
  464. comm.Review = review
  465. return review, comm, committer.Commit()
  466. }
  467. // GetReviewByIssueIDAndUserID get the latest review of reviewer for a pull request
  468. func GetReviewByIssueIDAndUserID(ctx context.Context, issueID, userID int64) (*Review, error) {
  469. review := new(Review)
  470. has, err := db.GetEngine(ctx).Where(
  471. builder.In("type", ReviewTypeApprove, ReviewTypeReject, ReviewTypeRequest).
  472. And(builder.Eq{"issue_id": issueID, "reviewer_id": userID, "original_author_id": 0})).
  473. Desc("id").
  474. Get(review)
  475. if err != nil {
  476. return nil, err
  477. }
  478. if !has {
  479. return nil, ErrReviewNotExist{}
  480. }
  481. return review, nil
  482. }
  483. // GetTeamReviewerByIssueIDAndTeamID get the latest review request of reviewer team for a pull request
  484. func GetTeamReviewerByIssueIDAndTeamID(ctx context.Context, issueID, teamID int64) (*Review, error) {
  485. review := new(Review)
  486. has, err := db.GetEngine(ctx).Where(builder.Eq{"issue_id": issueID, "reviewer_team_id": teamID}).
  487. Desc("id").
  488. Get(review)
  489. if err != nil {
  490. return nil, err
  491. }
  492. if !has {
  493. return nil, ErrReviewNotExist{0}
  494. }
  495. return review, err
  496. }
  497. // MarkReviewsAsStale marks existing reviews as stale
  498. func MarkReviewsAsStale(ctx context.Context, issueID int64) (err error) {
  499. _, err = db.GetEngine(ctx).Exec("UPDATE `review` SET stale=? WHERE issue_id=?", true, issueID)
  500. return err
  501. }
  502. // MarkReviewsAsNotStale marks existing reviews as not stale for a giving commit SHA
  503. func MarkReviewsAsNotStale(ctx context.Context, issueID int64, commitID string) (err error) {
  504. _, err = db.GetEngine(ctx).Exec("UPDATE `review` SET stale=? WHERE issue_id=? AND commit_id=?", false, issueID, commitID)
  505. return err
  506. }
  507. // DismissReview change the dismiss status of a review
  508. func DismissReview(ctx context.Context, review *Review, isDismiss bool) (err error) {
  509. if review.Dismissed == isDismiss || (review.Type != ReviewTypeApprove && review.Type != ReviewTypeReject) {
  510. return nil
  511. }
  512. review.Dismissed = isDismiss
  513. if review.ID == 0 {
  514. return ErrReviewNotExist{}
  515. }
  516. _, err = db.GetEngine(ctx).ID(review.ID).Cols("dismissed").Update(review)
  517. return err
  518. }
  519. // InsertReviews inserts review and review comments
  520. func InsertReviews(ctx context.Context, reviews []*Review) error {
  521. return db.WithTx(ctx, func(ctx context.Context) error {
  522. sess := db.GetEngine(ctx)
  523. for _, review := range reviews {
  524. if _, err := sess.NoAutoTime().Insert(review); err != nil {
  525. return err
  526. }
  527. if _, err := sess.NoAutoTime().Insert(&Comment{
  528. Type: CommentTypeReview,
  529. Content: review.Content,
  530. PosterID: review.ReviewerID,
  531. OriginalAuthor: review.OriginalAuthor,
  532. OriginalAuthorID: review.OriginalAuthorID,
  533. IssueID: review.IssueID,
  534. ReviewID: review.ID,
  535. CreatedUnix: review.CreatedUnix,
  536. UpdatedUnix: review.UpdatedUnix,
  537. }); err != nil {
  538. return err
  539. }
  540. for _, c := range review.Comments {
  541. c.ReviewID = review.ID
  542. }
  543. if len(review.Comments) > 0 {
  544. if _, err := sess.NoAutoTime().Insert(review.Comments); err != nil {
  545. return err
  546. }
  547. }
  548. if err := UpdateIssueNumComments(ctx, review.IssueID); err != nil {
  549. return err
  550. }
  551. }
  552. return nil
  553. })
  554. }
  555. // AddReviewRequest add a review request from one reviewer
  556. func AddReviewRequest(ctx context.Context, issue *Issue, reviewer, doer *user_model.User) (*Comment, error) {
  557. return db.WithTx2(ctx, func(ctx context.Context) (*Comment, error) {
  558. sess := db.GetEngine(ctx)
  559. review, err := GetReviewByIssueIDAndUserID(ctx, issue.ID, reviewer.ID)
  560. if err != nil && !IsErrReviewNotExist(err) {
  561. return nil, err
  562. }
  563. if review != nil {
  564. // skip it when reviewer has been request to review
  565. if review.Type == ReviewTypeRequest {
  566. return nil, nil // still commit the transaction, or committer.Close() will rollback it, even if it's a reused transaction.
  567. }
  568. if issue.IsClosed {
  569. return nil, ErrReviewRequestOnClosedPR{}
  570. }
  571. if issue.IsPull {
  572. if err := issue.LoadPullRequest(ctx); err != nil {
  573. return nil, err
  574. }
  575. if issue.PullRequest.HasMerged {
  576. return nil, ErrReviewRequestOnClosedPR{}
  577. }
  578. }
  579. }
  580. // if the reviewer is an official reviewer,
  581. // remove the official flag in the all previous reviews
  582. official, err := IsOfficialReviewer(ctx, issue, reviewer)
  583. if err != nil {
  584. return nil, err
  585. } else if official {
  586. if _, err := sess.Exec("UPDATE `review` SET official=? WHERE issue_id=? AND reviewer_id=?", false, issue.ID, reviewer.ID); err != nil {
  587. return nil, err
  588. }
  589. }
  590. review, err = CreateReview(ctx, CreateReviewOptions{
  591. Type: ReviewTypeRequest,
  592. Issue: issue,
  593. Reviewer: reviewer,
  594. Official: official,
  595. Stale: false,
  596. })
  597. if err != nil {
  598. return nil, err
  599. }
  600. comment, err := CreateComment(ctx, &CreateCommentOptions{
  601. Type: CommentTypeReviewRequest,
  602. Doer: doer,
  603. Repo: issue.Repo,
  604. Issue: issue,
  605. RemovedAssignee: false, // Use RemovedAssignee as !isRequest
  606. AssigneeID: reviewer.ID, // Use AssigneeID as reviewer ID
  607. ReviewID: review.ID,
  608. })
  609. if err != nil {
  610. return nil, err
  611. }
  612. // func caller use the created comment to retrieve created review too.
  613. comment.Review = review
  614. return comment, nil
  615. })
  616. }
  617. // RemoveReviewRequest remove a review request from one reviewer
  618. func RemoveReviewRequest(ctx context.Context, issue *Issue, reviewer, doer *user_model.User) (*Comment, error) {
  619. return db.WithTx2(ctx, func(ctx context.Context) (*Comment, error) {
  620. review, err := GetReviewByIssueIDAndUserID(ctx, issue.ID, reviewer.ID)
  621. if err != nil && !IsErrReviewNotExist(err) {
  622. return nil, err
  623. }
  624. if review == nil || review.Type != ReviewTypeRequest {
  625. return nil, nil
  626. }
  627. if _, err = db.DeleteByBean(ctx, review); err != nil {
  628. return nil, err
  629. }
  630. official, err := IsOfficialReviewer(ctx, issue, reviewer)
  631. if err != nil {
  632. return nil, err
  633. } else if official {
  634. if err := restoreLatestOfficialReview(ctx, issue.ID, reviewer.ID); err != nil {
  635. return nil, err
  636. }
  637. }
  638. return CreateComment(ctx, &CreateCommentOptions{
  639. Type: CommentTypeReviewRequest,
  640. Doer: doer,
  641. Repo: issue.Repo,
  642. Issue: issue,
  643. RemovedAssignee: true, // Use RemovedAssignee as !isRequest
  644. AssigneeID: reviewer.ID, // Use AssigneeID as reviewer ID
  645. })
  646. })
  647. }
  648. // Recalculate the latest official review for reviewer
  649. func restoreLatestOfficialReview(ctx context.Context, issueID, reviewerID int64) error {
  650. review, err := GetReviewByIssueIDAndUserID(ctx, issueID, reviewerID)
  651. if err != nil && !IsErrReviewNotExist(err) {
  652. return err
  653. }
  654. if review != nil {
  655. if _, err := db.Exec(ctx, "UPDATE `review` SET official=? WHERE id=?", true, review.ID); err != nil {
  656. return err
  657. }
  658. }
  659. return nil
  660. }
  661. // AddTeamReviewRequest add a review request from one team
  662. func AddTeamReviewRequest(ctx context.Context, issue *Issue, reviewer *organization.Team, doer *user_model.User) (*Comment, error) {
  663. return db.WithTx2(ctx, func(ctx context.Context) (*Comment, error) {
  664. review, err := GetTeamReviewerByIssueIDAndTeamID(ctx, issue.ID, reviewer.ID)
  665. if err != nil && !IsErrReviewNotExist(err) {
  666. return nil, err
  667. }
  668. // This team already has been requested to review - therefore skip this.
  669. if review != nil {
  670. return nil, nil
  671. }
  672. official, err := IsOfficialReviewerTeam(ctx, issue, reviewer)
  673. if err != nil {
  674. return nil, fmt.Errorf("isOfficialReviewerTeam(): %w", err)
  675. } else if !official {
  676. if official, err = IsOfficialReviewer(ctx, issue, doer); err != nil {
  677. return nil, fmt.Errorf("isOfficialReviewer(): %w", err)
  678. }
  679. }
  680. if review, err = CreateReview(ctx, CreateReviewOptions{
  681. Type: ReviewTypeRequest,
  682. Issue: issue,
  683. ReviewerTeam: reviewer,
  684. Official: official,
  685. Stale: false,
  686. }); err != nil {
  687. return nil, err
  688. }
  689. if official {
  690. if _, err := db.Exec(ctx, "UPDATE `review` SET official=? WHERE issue_id=? AND reviewer_team_id=?", false, issue.ID, reviewer.ID); err != nil {
  691. return nil, err
  692. }
  693. }
  694. comment, err := CreateComment(ctx, &CreateCommentOptions{
  695. Type: CommentTypeReviewRequest,
  696. Doer: doer,
  697. Repo: issue.Repo,
  698. Issue: issue,
  699. RemovedAssignee: false, // Use RemovedAssignee as !isRequest
  700. AssigneeTeamID: reviewer.ID, // Use AssigneeTeamID as reviewer team ID
  701. ReviewID: review.ID,
  702. })
  703. if err != nil {
  704. return nil, fmt.Errorf("CreateComment(): %w", err)
  705. }
  706. return comment, nil
  707. })
  708. }
  709. // RemoveTeamReviewRequest remove a review request from one team
  710. func RemoveTeamReviewRequest(ctx context.Context, issue *Issue, reviewer *organization.Team, doer *user_model.User) (*Comment, error) {
  711. return db.WithTx2(ctx, func(ctx context.Context) (*Comment, error) {
  712. review, err := GetTeamReviewerByIssueIDAndTeamID(ctx, issue.ID, reviewer.ID)
  713. if err != nil && !IsErrReviewNotExist(err) {
  714. return nil, err
  715. }
  716. if review == nil {
  717. return nil, nil
  718. }
  719. if _, err = db.DeleteByBean(ctx, review); err != nil {
  720. return nil, err
  721. }
  722. official, err := IsOfficialReviewerTeam(ctx, issue, reviewer)
  723. if err != nil {
  724. return nil, fmt.Errorf("isOfficialReviewerTeam(): %w", err)
  725. }
  726. if official {
  727. // recalculate which is the latest official review from that team
  728. review, err := GetReviewByIssueIDAndUserID(ctx, issue.ID, -reviewer.ID)
  729. if err != nil && !IsErrReviewNotExist(err) {
  730. return nil, err
  731. }
  732. if review != nil {
  733. if _, err := db.Exec(ctx, "UPDATE `review` SET official=? WHERE id=?", true, review.ID); err != nil {
  734. return nil, err
  735. }
  736. }
  737. }
  738. if doer == nil {
  739. return nil, nil
  740. }
  741. comment, err := CreateComment(ctx, &CreateCommentOptions{
  742. Type: CommentTypeReviewRequest,
  743. Doer: doer,
  744. Repo: issue.Repo,
  745. Issue: issue,
  746. RemovedAssignee: true, // Use RemovedAssignee as !isRequest
  747. AssigneeTeamID: reviewer.ID, // Use AssigneeTeamID as reviewer team ID
  748. })
  749. if err != nil {
  750. return nil, fmt.Errorf("CreateComment(): %w", err)
  751. }
  752. return comment, nil
  753. })
  754. }
  755. // MarkConversation Add or remove Conversation mark for a code comment
  756. func MarkConversation(ctx context.Context, comment *Comment, doer *user_model.User, isResolve bool) (err error) {
  757. if comment.Type != CommentTypeCode {
  758. return nil
  759. }
  760. if isResolve {
  761. if comment.ResolveDoerID != 0 {
  762. return nil
  763. }
  764. if _, err = db.GetEngine(ctx).Exec("UPDATE `comment` SET resolve_doer_id=? WHERE id=?", doer.ID, comment.ID); err != nil {
  765. return err
  766. }
  767. } else {
  768. if comment.ResolveDoerID == 0 {
  769. return nil
  770. }
  771. if _, err = db.GetEngine(ctx).Exec("UPDATE `comment` SET resolve_doer_id=? WHERE id=?", 0, comment.ID); err != nil {
  772. return err
  773. }
  774. }
  775. return nil
  776. }
  777. // CanMarkConversation Add or remove Conversation mark for a code comment permission check
  778. // the PR writer , official reviewer and poster can do it
  779. func CanMarkConversation(ctx context.Context, issue *Issue, doer *user_model.User) (permResult bool, err error) {
  780. if doer == nil || issue == nil {
  781. return false, errors.New("issue or doer is nil")
  782. }
  783. if err = issue.LoadRepo(ctx); err != nil {
  784. return false, err
  785. }
  786. if issue.Repo.IsArchived {
  787. return false, nil
  788. }
  789. if doer.ID != issue.PosterID {
  790. p, err := access_model.GetUserRepoPermission(ctx, issue.Repo, doer)
  791. if err != nil {
  792. return false, err
  793. }
  794. permResult = p.CanAccess(perm.AccessModeWrite, unit.TypePullRequests)
  795. if !permResult {
  796. if permResult, err = IsOfficialReviewer(ctx, issue, doer); err != nil {
  797. return false, err
  798. }
  799. }
  800. if !permResult {
  801. return false, nil
  802. }
  803. }
  804. return true, nil
  805. }
  806. // DeleteReview delete a review and it's code comments
  807. func DeleteReview(ctx context.Context, r *Review) error {
  808. return db.WithTx(ctx, func(ctx context.Context) error {
  809. if r.ID == 0 {
  810. return errors.New("review is not allowed to be 0")
  811. }
  812. if r.Type == ReviewTypeRequest {
  813. return errors.New("review request can not be deleted using this method")
  814. }
  815. opts := FindCommentsOptions{
  816. Type: CommentTypeCode,
  817. IssueID: r.IssueID,
  818. ReviewID: r.ID,
  819. }
  820. if _, err := db.Delete[Comment](ctx, opts); err != nil {
  821. return err
  822. }
  823. opts = FindCommentsOptions{
  824. Type: CommentTypeReview,
  825. IssueID: r.IssueID,
  826. ReviewID: r.ID,
  827. }
  828. if _, err := db.Delete[Comment](ctx, opts); err != nil {
  829. return err
  830. }
  831. opts = FindCommentsOptions{
  832. Type: CommentTypeDismissReview,
  833. IssueID: r.IssueID,
  834. ReviewID: r.ID,
  835. }
  836. if _, err := db.Delete[Comment](ctx, opts); err != nil {
  837. return err
  838. }
  839. if _, err := db.DeleteByID[Review](ctx, r.ID); err != nil {
  840. return err
  841. }
  842. if r.Official {
  843. if err := restoreLatestOfficialReview(ctx, r.IssueID, r.ReviewerID); err != nil {
  844. return err
  845. }
  846. }
  847. return nil
  848. })
  849. }
  850. // GetCodeCommentsCount return count of CodeComments a Review has
  851. func (r *Review) GetCodeCommentsCount(ctx context.Context) int {
  852. opts := FindCommentsOptions{
  853. Type: CommentTypeCode,
  854. IssueID: r.IssueID,
  855. ReviewID: r.ID,
  856. }
  857. conds := opts.ToConds()
  858. if r.ID == 0 {
  859. conds = conds.And(builder.Eq{"invalidated": false})
  860. }
  861. count, err := db.GetEngine(ctx).Where(conds).Count(new(Comment))
  862. if err != nil {
  863. return 0
  864. }
  865. return int(count)
  866. }
  867. // HTMLURL formats a URL-string to the related review issue-comment
  868. func (r *Review) HTMLURL(ctx context.Context) string {
  869. opts := FindCommentsOptions{
  870. Type: CommentTypeReview,
  871. IssueID: r.IssueID,
  872. ReviewID: r.ID,
  873. }
  874. comment := new(Comment)
  875. has, err := db.GetEngine(ctx).Where(opts.ToConds()).Get(comment)
  876. if err != nil || !has {
  877. return ""
  878. }
  879. return comment.HTMLURL(ctx)
  880. }
  881. // RemapExternalUser ExternalUserRemappable interface
  882. func (r *Review) RemapExternalUser(externalName string, externalID, userID int64) error {
  883. r.OriginalAuthor = externalName
  884. r.OriginalAuthorID = externalID
  885. r.ReviewerID = userID
  886. return nil
  887. }
  888. // GetUserID ExternalUserRemappable interface
  889. func (r *Review) GetUserID() int64 { return r.ReviewerID }
  890. // GetExternalName ExternalUserRemappable interface
  891. func (r *Review) GetExternalName() string { return r.OriginalAuthor }
  892. // GetExternalID ExternalUserRemappable interface
  893. func (r *Review) GetExternalID() int64 { return r.OriginalAuthorID }
  894. // UpdateReviewsMigrationsByType updates reviews' migrations information via given git service type and original id and poster id
  895. func UpdateReviewsMigrationsByType(ctx context.Context, tp structs.GitServiceType, originalAuthorID string, posterID int64) error {
  896. _, err := db.GetEngine(ctx).Table("review").
  897. Where("original_author_id = ?", originalAuthorID).
  898. And(migratedIssueCond(tp)).
  899. Update(map[string]any{
  900. "reviewer_id": posterID,
  901. "original_author": "",
  902. "original_author_id": 0,
  903. })
  904. return err
  905. }